-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create k3s.md #246
base: main
Are you sure you want to change the base?
Create k3s.md #246
Conversation
This PR addresses the issue of missing documentation for integrating WasmEdge with k3s, a lightweight Kubernetes distribution ideal for edge computing. The goal is to provide a comprehensive guide that outlines the necessary steps for configuring and deploying WasmEdge applications on a k3s cluster. Signed-off-by: Anshika Vashistha <[email protected]>
Hello, I am a PR summary agent on flows.network. Here are my reviews of code commits in this PR. Overall, the GitHub patch introduces a new documentation file that provides instructions for integrating WasmEdge with k3s. This is a significant addition as it addresses the missing documentation issue and offers valuable guidance for configuring and deploying WasmEdge applications on a k3s cluster. However, there are some potential issues to note:
The most important findings are:
Users should be aware of the updated Docker Desktop version requirement and the removal of the "quick_start_docker.md" file to avoid potential errors or confusion. DetailsCommit 495ab8c0b119c86c651b4d91024d1421a249802d
Commit c7e96b2ca0a326474ad7319d744997983141cb81
Commit e12b80999faea6095556fd1cd0455ea8ff2897f3The key changes in this GitHub patch are:
Without further context, it's difficult to determine the exact reason for the deletion of this file. |
@juntao @dannypsnl PTAL |
Signed-off-by: Anshika Vashistha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you run the steps you wrote in the document?
Yes I have run these steps |
Signed-off-by: Anshika Vashistha <[email protected]>
Which Wasm application do you use for the example? |
Expected Output of the Execution Result
|
|
You didn't show the output generated by the wasm application. The YAML you provided is just the configuration. |
This PR addresses the issue of missing documentation for integrating WasmEdge with k3s, a lightweight Kubernetes distribution ideal for edge computing. The goal is to provide a comprehensive guide that outlines the necessary steps for configuring and deploying WasmEdge applications on a k3s cluster.
Explanation
Related issue
Fixes #2132
What type of PR is this
Proposed Changes